-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds internal timezone_from_offset function #3648
Conversation
1e4d38e
to
c06223b
Compare
This change is a first step for #3633. It allows to remove all C API calls from the I am not sure adding two functions is the best way to go. An other option might be to convert the three functions constructing |
c5a6c97
to
8ec500b
Compare
Note that there is a long history of why these functions don't exist, see #1588 (comment) I'm not totally against adding them, but also do understand why others did not want them. |
8ec500b
to
1ec9d0a
Compare
9dc3ea0
to
418e0cb
Compare
Thank you! I was not aware of this discussion. The concerns make sense. I have rewritten this MR to make |
418e0cb
to
6c739d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this now looks like it just relocated the function, but I've no problem with that if it's a helpful first step for the follow up feature work 👍
It allows to build conversions from chrono without direct access to the C API
6c739d6
to
dcaed19
Compare
Adds internal timezone_from_offset function
It allows to build conversions from chrono without direct access to the C API